Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Paramedic and CMO uniform #1637

Closed

Conversation

HecoWolff
Copy link

Что этот PR делает

Добавляет униформу для парамедика, а так же для СМО.
Парамедику:
-Сьют парамедика;
-Разгрузочный пояс;
-Берет парамедика.

Для СМО:
-Парадная форма СМО, женская;
-Парадная форма СМО, мужская;
-Берет СМО;
-Мантия СМО.

Униформа парамедика доступна в вендомате меда.
Униформа СМО доступна в его шкафу.

Почему это хорошо для игры

У СМО и парамедика появится выбор в одежде.

Изображения изменений

image
image
image
image
image

Тестирование

Тестировалось на локалке, все работает, отображается и выдается.

Changelog

🆑
add: Добавил форму парамедика и СМО.
/:cl:

@github-actions github-actions bot added the 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! label Nov 3, 2024
@ss220bot ss220bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Nov 3, 2024
Copy link
Collaborator

@dj-34 dj-34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перебор контраста на парадной форме и недостаток глянца на обычной (очень плоские цвета, в частности на синих полосах и оттенках белого).

image
image

Copy link
Collaborator

@dj-34 dj-34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Касаемо мантии спорно, её на оффах неплохо перерисовали.

)

/obj/item/storage/belt/medical/medicalwebbing
name = "Медицинский разгрузочный пояс"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

все name на английском с маленькой буквы

"Nucleation" = 'modular_ss220/jobs/icons/clothing/mob/head.dmi',
)

/obj/item/storage/belt/medical/medicalwebbing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И так понятно что medical

Suggested change
/obj/item/storage/belt/medical/medicalwebbing
/obj/item/storage/belt/medical/webbing

"Nucleation" = 'modular_ss220/jobs/icons/clothing/mob/uniform.dmi',
)

/obj/item/clothing/under/rank/medical/chief_medical_officer/skirt2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А у нас есть skirt1?
Если нет, в таком случаи либо skirt_parade, либо skirt_alt

Comment on lines +47 to +63
/obj/item/clothing/suit/mantle/cmo
name = "Мантия СМО"
desc = "Статусная мантия СМО."
icon = 'modular_ss220/jobs/icons/clothing/suits.dmi'
icon_state = "cmomantle"
icon_override = 'modular_ss220/jobs/icons/clothing/mob/suits.dmi'
flags_inv = HIDEJUMPSUIT

/obj/item/clothing/under/rank/medical/paramedic/suit
name = "Форма парамедика"
desc = "Форма парамедика, смотрится стильно и просто."
icon = 'modular_ss220/jobs/icons/clothing/uniforms.dmi'
icon_state = "paramed2"
item_color = "paramed2"
icon_override = 'modular_ss220/jobs/icons/clothing/mob/uniform.dmi'
sprite_sheets = list(
"Abductor" = 'modular_ss220/jobs/icons/clothing/mob/uniform.dmi',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это всё в modular_ss220/clothing

Comment on lines +1 to +6
/obj/item/storage/bag/garment/chief_medical_officer/populate_contents()
. = ..()
new /obj/item/clothing/suit/mantle/cmo(src)
new /obj/item/clothing/under/rank/medical/chief_medical_officer/skirt2(src)
new /obj/item/clothing/under/rank/medical/chief_medical_officer/suit(src)
new /obj/item/clothing/head/beret/cmo(src)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в modular_ss220\clothing\code\garment_bag.dm

@@ -38,3 +38,16 @@
/obj/item/clothing/under/rank/engineering/engineer/trainee/assistant = 5,
/obj/item/clothing/under/rank/engineering/engineer/trainee/assistant/skirt = 5,
)

/obj/machinery/economy/vending/medidrobe/Initialize(mapload)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в modular_ss220\clothing\code\clothing_vendors.dm

"Nucleation" = 'modular_ss220/jobs/icons/clothing/mob/uniform.dmi',
)

/obj/item/clothing/under/rank/medical/chief_medical_officer/suit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suit?

icon_override = 'modular_ss220/jobs/icons/clothing/mob/suits.dmi'
flags_inv = HIDEJUMPSUIT

/obj/item/clothing/under/rank/medical/paramedic/suit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже не suit

@dj-34 dj-34 changed the title paramedic and cmo uniform Add: Paramedic and CMO uniform Nov 3, 2024
Copy link

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale ПР долго был не активен, и требует обновления. label Nov 18, 2024
Copy link
Collaborator

@PhantornRU PhantornRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Заброшено?

@github-actions github-actions bot removed the Stale ПР долго был не активен, и требует обновления. label Nov 19, 2024
Copy link

github-actions bot commented Dec 3, 2024

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale ПР долго был не активен, и требует обновления. label Dec 3, 2024
Copy link

This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates.

@github-actions github-actions bot closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! 📜 CL валиден Этот чейнджлог будет успешно опубликован Stale ПР долго был не активен, и требует обновления.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants